Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMassProperties to reflect rapier's mass properties #411

Merged
merged 14 commits into from
Aug 6, 2023

Conversation

Aceeri
Copy link
Contributor

@Aceeri Aceeri commented Jul 28, 2023

Also protects the internal MassProperties from direct modification.

Currently a relatively un-optimized version where I don't even try to guess when it would change.

I think I'd like to change this to update only if one of these has changed:

  • ColliderMassProperties
  • Collider::scale
  • AdditionalMassProperties

@Aceeri
Copy link
Contributor Author

Aceeri commented Jul 28, 2023

Should be a bit more optimized now, only updates the ReadMassProperties based on the changes mentioned above.

@sebcrozet sebcrozet merged commit a149ff5 into dimforge:master Aug 6, 2023
3 checks passed
@sebcrozet
Copy link
Member

Thanks! I renamed MassModified to MassModifiedEvent.

@Aceeri Aceeri deleted the read-mass-properties branch August 7, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants