Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby and Node #1873

Merged
merged 1 commit into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ jobs:
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.6'
ruby-version: '3.4.1'
bundler-cache: true
- uses: pnpm/action-setup@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: 'pnpm'
- name: Install node dependencies
run: pnpm install
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
if: steps.changed-files.outputs.any_changed == 'true'
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.6'
ruby-version: '3.4.1'
bundler-cache: true
- name: Run RuboCop
if: steps.changed-files.outputs.any_changed == 'true'
Expand All @@ -53,7 +53,7 @@ jobs:
if: steps.changed-files.outputs.any_changed == 'true'
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3.6'
ruby-version: '3.4.1'
bundler-cache: true
- name: Run Slim-Lint
if: steps.changed-files.outputs.any_changed == 'true'
Expand All @@ -78,7 +78,7 @@ jobs:
if: steps.changed-files.outputs.any_changed == 'true'
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: 'pnpm'
- name: Install node dependencies
run: pnpm install
Expand All @@ -104,7 +104,7 @@ jobs:
if: steps.changed-files.outputs.any_changed == 'true'
uses: actions/setup-node@v4
with:
node-version: '20'
node-version: '22'
cache: 'pnpm'
- name: Install node dependencies
run: pnpm install
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ require:

AllCops:
TargetRailsVersion: 7.1
TargetRubyVersion: 3.3
TargetRubyVersion: 3.4
NewCops: enable
DisplayStyleGuide: true
ExtraDetails: true
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ git_source(:github) do |repo_name|
"https://github.com/#{repo_name}.git"
end

ruby '3.3.6'
ruby '3.4.1'

gem 'rails', '7.1.5.1'

Expand Down
3 changes: 1 addition & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ GEM
net-protocol (0.2.2)
timeout
net-smtp (0.5.0)
net-protocol
netrc (0.11.0)
newrelic_rpm (9.16.1)
nio4r (2.7.4)
Expand Down Expand Up @@ -547,7 +546,7 @@ DEPENDENCIES
webmock

RUBY VERSION
ruby 3.3.6p108
ruby 3.4.1p0

BUNDLED WITH
2.6.3
2 changes: 1 addition & 1 deletion docker/icare/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# syntax = docker/dockerfile:1

# Make sure RUBY_VERSION matches the Ruby version in .ruby-version and Gemfile
ARG RUBY_VERSION=3.3.6
ARG RUBY_VERSION=3.4.1
FROM registry.docker.com/library/ruby:$RUBY_VERSION-slim as base

# Rails app lives here
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"private": true,
"version": "1.0.0",
"engines": {
"node": ">= 20.0",
"node": ">= 22.0",
"pnpm": "^9.12.1"
},
"packageManager": "pnpm@^9.12.1",
Expand Down