Allow empty values in IC #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremykubica
approved these changes
Sep 6, 2024
wilsonbb
approved these changes
Sep 9, 2024
DinoBektesevic
force-pushed
the
ic/allow_empty_values
branch
from
6341e9e
to
8936030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow some values in columns to be empty strings, or their equivalent falsy values.
This is not a good fix because autocasting rules sometimes could cast the column as masked column, but required for the data that was processed with the different stack version. The fix is to set a default non-falsy value in the ButlerStandardizers for the properties that the new stack versions may return as
Noneor "" when using an older stack version.Blocked by #694