Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty values in IC #695

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Allow empty values in IC #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/kbmod/image_collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,14 +716,12 @@ def _validate(self):
warnings.simplefilter("ignore", category=FutureWarning)
test1 = None in self.data[col]
test1 = test1 if isinstance(test1, bool) else test1.any()
test2 = "" in self.data[col]
test2 = test2 if isinstance(test2, bool) else test2.any()
if test1 or test2:
return False, "missing required self.data values: {col}"
if test1:
return False, f"missing required self.data values: {col}"

for col in shared_cols:
if self.data.meta[col] is None or self.data.meta[col] == "":
return False, "missing required self.data values: {col}"
return False, f"missing required self.data values: {col}"

return True, ""

Expand Down
Loading