Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20763 - Inconsistent handling of type + value in typeof expressions #20798

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jan 28, 2025

Closes #20763

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20798"

@dkorpel dkorpel force-pushed the typeof-type-addition branch from 6a8bdda to c94c2a2 Compare January 28, 2025 22:55
compiler/src/dmd/expressionsem.d Outdated Show resolved Hide resolved
compiler/src/dmd/expressionsem.d Outdated Show resolved Hide resolved
@dkorpel dkorpel force-pushed the typeof-type-addition branch from c36a8e2 to 5b994fb Compare January 28, 2025 23:29
@dkorpel dkorpel merged commit 28bc5c6 into dlang:master Jan 29, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent handling of type + value in typeof expressions
3 participants