detail work on double to integer conversion #20810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Compiler:Backend
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20810" |
thewilsonator
approved these changes
Feb 2, 2025
MatthewQiu-5
pushed a commit
to MatthewQiu-5/dmd
that referenced
this pull request
Feb 4, 2025
Extracted attrib.StaticForeachDeclaration.oneMember Extracted attrib.StorageDeclaration.oneMember Removed unused import in attrib.d removed additional unused import in attrib.d extracted remaining instances of oneMember() changed return to result setting remove onemember from instance methods in frontend.h added pointer to function signature of onemember fixed oneMember typo in cxxfrontend.d temporary new sem dependency as a result of oneMembers() dependency on oneMember() Extract attrib.oneMember and move it to visitor Extract attrib.oneMember and move it to visitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carefully went over cdcnvt() again, adding more test cases to the disassembler. Doesn't look like much when I finish it :-/
After this, do the integer=>float conversions.