Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache not updated if a page is renamed through a workspace #528

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

cache not updated if a page is renamed through a workspace #528

wants to merge 1 commit into from

Conversation

bill622
Copy link

@bill622 bill622 commented Sep 8, 2017

I know workspaces are less used, but where I work we really need them... So this code solve a cache bug when a page is being renamed in a workspace then published to live. The Url cache is now updated if a version change occurs.

…ce and then published instead of being renamed straight in Live
@dmitryd
Copy link
Owner

dmitryd commented Sep 13, 2017

RealURL does not work with workspaces. This is officially documented.

$badPathPart = implode('/', $nonProcessedArray);
$badPathPartPos = strrpos($this->originalPath, $badPathPart);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed here? It is not used outside of else block below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants