Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache not updated if a page is renamed through a workspace #528

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

cache not updated if a page is renamed through a workspace #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Classes/Decoder/UrlDecoder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,8 +1122,9 @@ protected function handleFileNameMappingToGetVar(&$fileNameSegment, array &$getV
protected function handleNonExistingPostVarSet($pageId, $postVarSetKey, array &$pathSegments) {
$failureMode = $this->configuration->get('init/postVarSet_failureMode');
if ($failureMode == 'redirect_goodUpperDir') {
$nonProcessedArray = array($postVarSetKey) + $pathSegments;
$nonProcessedArray = array_merge( array($postVarSetKey), $pathSegments );
$badPathPart = implode('/', $nonProcessedArray);
$badPathPartPos = strrpos($this->originalPath, $badPathPart);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed here? It is not used outside of else block below.

$badPathPartLength = strlen($badPathPart);
if (strpos($badPathPart, '/') !== FALSE || $badPathPartLength === 0) {
// There are two or more adjacent slashes in the URL, e.g. "good/good//index.html" or "good/good//bad///index.html"
Expand Down
2 changes: 1 addition & 1 deletion Classes/Hooks/DataHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function processCmdmap_deleteAction($table, $id) {
* @param int $id
*/
public function processCmdmap_postProcess($command, $table, $id) {
if ($command === 'move' && $table === 'pages') {
if ( ( $command === 'move' || $command === "version" ) && $table === 'pages') {
$this->expireCachesForPageAndSubpages((int)$id, 0);

$languageOverlays = $this->getRecordsByField('pages_language_overlay', 'pid', $id);
Expand Down