Drools - Fix TCK tests failing because of a compilation failure #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests 0092 and 1131 of TCK Tests suite are not executed because a failure occurs during the compilation of the related DMN files.
Those DMN files contain references to unexisting functions, so it's expected that the compilation fail.
As the TCK Tests suite is relying on the "old" KieContainer API, is not possible to separate the compilation and the execution phases.
So, the solution is to use the "new" API layer that doesn't have this strict phase management
@baldimir @gitgabrio
Before this change:
[ERROR] Tests run: 6618, Failures: 0, Errors: 36, Skipped: 0After this change:
[ERROR] Tests run: 6667, Failures: 0, Errors: 35, Skipped: 0`