Set processing version as integer #11040
Conversation
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
@amaltaro , now all unit tests are fine and code is ready for review. |
|
Jenkins results:
|
There was a problem hiding this comment.
Valentin, most of these changes are actually not necessary.
As we discussed yesterday, the best way to address it would be with a database schema change, here:
https://github.com/dmwm/WMCore/blob/master/src/python/WMComponent/DBS3Buffer/MySQL/Create.py#L31
and in its equivalent Oracle Create module (replace MySQL by Oracle in that path and you will find the schema creation for Oracle).
|
Jenkins results:
|
vkuznet
force-pushed
the
fix-procVer
branch
2 times, most recently
from
8fd2f2f
to
7ad65f9
Compare
|
Jenkins results:
|
|
Jenkins results:
|
|
Jenkins results:
|
|
Alan, all tests passed, I adjusted code to your comments, please review it again. |
|
this seems to be duplicate of #11043 |
|
Let me close this one out to avoid confusions then. Please reopen it if I closed the wrong one. |
Fixes #10844
Status
not-tested
Description
In DBS processing version is defined as integer. During WMA integration tests with new DBS Go server I identified the following error:
which means that processing version was not passed as integer. Indeed, I found that in bulkblocks API call it passed as following:
I looked up all possible
def setProcessingVerfunctions and adjusted their code to ensure int data type. Unless if it is set by other method I think these changes should ensure that it is converted to integer data-type. Please note, I did not put any checks on provided values and therefore ifint(...)function will fail it will cause the exception. We will need to run integration tests again to see if we either fixed the issue or will get an exception.Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
<If it's a follow up work; or porting a fix from a different branch, please mention them here.>
External dependencies / deployment changes
<Does it require deployment changes? Does it rely on third-party libraries?>