Avoid returning null from EntityManager::getReference() and getPartialReference()
#8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
reference-null
branch
3 times, most recently
from
92b5ac0
to
a1a58fe
Compare
lcobucci
reviewed
Aug 16, 2021
|
This is inconsistent from my POV, |
|
@beberlei but this does not do any entity lookup. Currently, null is returned when there's issue with entity hierarchy when inheritance is used and that should IMO be an error. |
simPod
force-pushed
the
reference-null
branch
3 times, most recently
from
53434ca
to
a4f9c16
Compare
simPod
force-pushed
the
reference-null
branch
2 times, most recently
from
a934970
to
05d1161
Compare
derrabus
reviewed
Dec 28, 2021
lib/Doctrine/ORM/Exception/InstanceOfTheWrongTypeEncountered.php
Outdated
Show resolved
Hide resolved
simPod
force-pushed
the
reference-null
branch
from
13cc39b
to
a8811af
Compare
derrabus
reviewed
Dec 28, 2021
|
Before more work is done here, i believe the BC break here is too big to be reasonable and i am heavily 👎 on this change |
|
@beberlei what about adding new methods if BC break is the issue even for the major version? |
simPod
force-pushed
the
reference-null
branch
2 times, most recently
from
4fd4c6d
to
a3127c5
Compare
simPod
force-pushed
the
reference-null
branch
2 times, most recently
from
376fe53
to
5599b3f
Compare
…tialReference()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bothers me for a long time, though I'm not sure the solution is viable.
Though I'd rather not assert for
notNullevery time I use the reference.