Fix return type at EntityManagerInterface::get(Partial)Reference()
#8922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable. Can you make PHPStan and Psalm happy? |
|
Ok, it's happy now. |
|
Looks like we need to do the same with |
derrabus
approved these changes
Sep 11, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 11, 2021
* 2.9.x: Fix return type at `EntityManagerInterface::get(Partial)Reference()` (doctrine#8922) Fix class casing and avoid name collisions Remove unused performance base test class Drop unused test base classes Fix mapped superclass missing in discriminator map
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 11, 2021
* 2.9.x: Add extension point for the "embedded" XML node (doctrine#8992) Fix return type at `EntityManagerInterface::get(Partial)Reference()` (doctrine#8922) Fix class casing and avoid name collisions Remove unused performance base test class Drop unused test base classes Fix mapped superclass missing in discriminator map
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Sep 11, 2021
* 2.9.x: Remove Proxy from EntityManagerInterface contract Add extension point for the "embedded" XML node (doctrine#8992) Fix return type at `EntityManagerInterface::get(Partial)Reference()` (doctrine#8922) Fix class casing and avoid name collisions Remove unused performance base test class Drop unused test base classes Fix mapped superclass missing in discriminator map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lcobucci mentioned this in #8920 (comment)