Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix issue #82 #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

PR: Fix issue #82 #91

wants to merge 3 commits into from

Conversation

vvanmol
Copy link

@vvanmol vvanmol commented Jan 29, 2018

This PR includes a possible fix for Issue #82.

Please accept the merge if you agree, otherwise let me know how would you see this fixed.

Regards

@silvae86
Copy link

Any news on this?

@pkyeck
Copy link

pkyeck commented Mar 12, 2018

If this is a fix for the security problem, it would be great to have this merged ... and a new version published to npm

@vvanmol
Copy link
Author

vvanmol commented Mar 12, 2018

I never got any answer to the PR...

@gcphost
Copy link

gcphost commented May 11, 2018

Almost 2 months later bump.

https://nodesecurity.io/advisories/537

This package is looking a bit stale.

@woodyrew
Copy link

@dodo Any chance of this being merged?

@gcphost
Copy link

gcphost commented May 15, 2018

@woodyrew
Slugify is still active.
https://www.npmjs.com/package/slugify

@hawkeye64
Copy link

Still waiting... :(

@Ilshidur
Copy link

Last commit/publish was 3 years ago and the main maintainer does not seem to be very active on GitHub currently 😕
I'm afraid some people have to pick alternatives like https://www.npmjs.com/package/slugify or https://www.npmjs.com/package/mollusc (active fork of this package) until this gets fixed.

@woodyrew
Copy link

Ironically, node-slug seems like it's owner: dead like a @dodo

@StoneCypher
Copy link

@dodo , please merge or nominate a maintainer

@Trott
Copy link

Trott commented Oct 25, 2018

0.9.2 has been published with this issue fixed. https://www.npmjs.com/package/slug/v/0.9.2

@vvanmol Can you close this?

@woodyrew
Copy link

@Trott The changes haven't been pushed to this repo. Version is still 0.9.1 in package.json

@vvanmol
Copy link
Author

vvanmol commented Oct 25, 2018

Hi @Trott
As mentioned by @woodyrew the new release is not part of this repository, I don't see my PR merged here... Did you take ownership of the repository somewhere else ?

@Trott
Copy link

Trott commented Oct 25, 2018

@Trott The changes haven't been pushed to this repo. Version is still 0.9.1 in package.json

@woodyrew That's because I don't have write access to this repo. I do have access to publish the module on npm though, so I did the update in my own fork and published that to npm as 0.9.2. @dodo seems to be unreachable, but if they ever pop up again, I'm more than happy to turn anything and everything back over to them (or not--whatever they want). But until then... that's the situation.

I have a question in to a GitHub employee about whether GitHub has a process for this kind of situation that would allow me to get write access to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants