Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SELECT ... INTO OUTFILE ... tests #7463

Merged
merged 13 commits into from
Feb 9, 2024
Merged

SELECT ... INTO OUTFILE ... tests #7463

merged 13 commits into from
Feb 9, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 6, 2024

This PR adds BATS tests for a SELECT ... INTO OUTFILE ... feature we're adding.

Companion pr: dolthub/go-mysql-server#2317

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
0b0009c not ok 26
0b0009c ok 5937431
version total_tests
0b0009c 5937457
correctness_percentage
99.999562

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
285f77e not ok 26
285f77e ok 5937431
version total_tests
285f77e 5937457
correctness_percentage
99.999562

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
81aff65 not ok 26
81aff65 ok 5937431
version total_tests
81aff65 5937457
correctness_percentage
99.999562

@jycor jycor changed the title bump and test SELECT ... INTO OUTFILE ... tests Feb 8, 2024
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although we should add the new TestSelectIntoFile function into dolt_engine_test.go, too.

@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
fe5547d not ok 26
fe5547d ok 5937431
version total_tests
fe5547d 5937457
correctness_percentage
99.999562

James Cor added 2 commits February 9, 2024 01:28
@coffeegoddd
Copy link
Contributor

@jycor DOLT

comparing_percentages
99.999562 to 99.999562
version result total
476c04e not ok 26
476c04e ok 5937431
version total_tests
476c04e 5937457
correctness_percentage
99.999562

@Hydrocharged Hydrocharged merged commit d391bcf into main Feb 9, 2024
21 checks passed
@Hydrocharged Hydrocharged deleted the james/select-into branch February 9, 2024 13:28
Copy link

github-actions bot commented Feb 9, 2024

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.06 0.5
batching batch sql 10000 1 0.07 1.43
batching by line sql 10000 1 0.07 1.57
blob 1 blob 200000 1 0.89 3.22 3.54
blob 2 blobs 200000 1 0.88 4.09 4.74
blob no blob 200000 1 0.89 1.27 1.39
col type datetime 200000 1 0.81 1.77 1.99
col type varchar 200000 1 0.69 1.94 1.93
config width 2 cols 200000 1 0.79 1.22 1.29
config width 32 cols 200000 1 1.87 1.42 2.51
config width 8 cols 200000 1 1 1.29 1.54
pk type float 200000 1 0.89 1.17 1.17
pk type int 200000 1 0.81 1.17 1.25
pk type varchar 200000 1 1.54 1.14 0.94
row count 1.6mm 1600000 1 5.73 1.44 1.5
row count 400k 400000 1 1.47 1.36 1.42
row count 800k 800000 1 2.9 1.4 1.47
secondary index four index 200000 1 3.66 1.03 0.89
secondary index no secondary 200000 1 0.9 1.23 1.37
secondary index one index 200000 1 1.15 1.42 1.43
secondary index two index 200000 1 2.03 1.18 1.09
sorting shuffled 1mm 1000000 0 5.25 1.71 1.75
sorting sorted 1mm 1000000 1 5.25 1.73 1.74

Copy link

github-actions bot commented Feb 9, 2024

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.38
dolt_blame_commit_filter system table 3.57
dolt_commit_ancestors_commit_filter system table 0.82
dolt_commits_commit_filter system table 0.94
dolt_diff_log_join_from_commit system table 1.74
dolt_diff_log_join_to_commit system table 1.72
dolt_diff_table_from_commit_filter system table 1.15
dolt_diff_table_to_commit_filter system table 1.19
dolt_diffs_commit_filter system table 1.06
dolt_history_commit_filter system table 1.47
dolt_log_commit_filter system table 0.94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants