-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BinaryFormatter Migration Guide: Formatting, exception type, API links #42088
BinaryFormatter Migration Guide: Formatting, exception type, API links #42088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those, looks great!
OK -- the links to the binaryformatter-security-guide are finally correct. It required:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall looks good.
I think it would be better to use the xref style links rather than the page links for API reference.
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
docs/standard/serialization/binaryformatter-migration-guide/read-nrbf-payloads.md
Outdated
Show resolved
Hide resolved
@BillWagner I've replaced all use of links to API with |
For the BinaryFormatter Migration Guide:
PlatformNotSupportedException
)NrbfDecoder
APIsInternal previews