Unify dotnet/runtime on using Arcade -publish #108990
Open
+194
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet/source-build#4239 Replaces dotnet#100004 Co-authored By: Viktor Hofer <[email protected]>
ViktorHofer
reviewed
Oct 17, 2024
…VMR-like context, even repo build.
This was referenced Oct 17, 2024
This was referenced Oct 18, 2024
|
Unfortunately this won't work because of https://github.com/dotnet/arcade/blob/31624193093a13f765ab5382509e693911264509/src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj#L98 You will notice this when you update this branch with latest main (which has an updated Arcade). You can fix this by adding an "Empty.proj" file which as the name says is empty and pass that in as a |
|
I wish there was a "restore toolset"-only option... I guess I'll add the empty.csproj. Really hate that pattern. |
|
I have an idea on how to avoid the empty.proj pattern. I'll try it out and see what happens. |
…way from the Arcade SDK.
|
Yeah that's more or less the same just without an additional project. You are now also building the repo tasks unnecessarily but that should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4239
Replaces #100004
Current official build link: https://dev.azure.com/dnceng/internal/_build/results?buildId=2564097&view=results