-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Dotnet and Arcade #1197
Conversation
… few git-ignores.
… of Arcade with Dotnet.Spark
LICENSE
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split this into another PR? Since we are not familiar with this, we may need to involve some people from legal department to review. Splitting them would be clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's part of Arcade validation pipeline, the same license is used all dotnet MIT projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, let me check how to handle this.
@@ -151,7 +151,6 @@ extends: | |||
- script: build.cmd -pack | |||
-c $(buildConfiguration) | |||
-ci | |||
$(_OfficialBuildIdArgs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed vscode config as a separate commit Btw, there's .NET9 already available, but it's not LTS, so I still chose .NET8. Does my logic make sense to you? |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@wudanzy build timed out, could you please share the logs where exactly did it stall? |
Maybe flaky, retried. |
Hi @grazy27, you have more experience than me on .NET. Do you know if the upgraded .NET 8 (or net48) runtime can run spark jobs compiled by .NET 6 (or net47)? Or do we need an integration test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my sides, let @SparkSnail to have another look
In order to update Dotnet.Spark users will have to pull a new nuget, rebuild their project, and test that it's upgraded successfully. And if spark.worker is used - copypaste dlls to accessible location for it Overall CLRs of 6 & 8, and 4.6 & 4.8 are compatible, This situation can theoretically occur with spark.worker and UDF dlls, if users decide not to upgrade their project to 8: |
``` | ||
You should see JARs created for the supported Spark versions: | ||
* `microsoft-spark-2-3/target/microsoft-spark-2-3_2.11-<version>.jar` | ||
* `microsoft-spark-2-4/target/microsoft-spark-2-4_2.11-<version>.jar` | ||
* `microsoft-spark-3-0/target/microsoft-spark-3-0_2.12-<version>.jar` | ||
* `microsoft-spark-3-0/target/microsoft-spark-3-5_2.12-<version>.jar` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I'll fix in the next PR
@SparkSnail @grazy27 @wudanzy @radical @shanselman what are next to do list? |
There is some discussion in #1162, and I personally want to remove 2.X support. |
Changes:
Affected Tickets: