-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Dotnet and Arcade #1197
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9a57f1b
Updated .NET6 to .NET8, .net framework 4.6 to 4.8, and dependencies.
grazy27 2c38b08
Fixed build failure, logic for bulding path to a test folder, added a…
grazy27 0d9b55c
Copy-pasted Arcade 8 common folder
grazy27 9b1a0b8
Update of Arcade: Modified versions, and merged default configuration…
grazy27 7003f9c
Removed unneeded vs code configuration file, and added it to gitignore
grazy27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,11 +2,13 @@ Building Spark .NET on Ubuntu 18.04 | |
========================== | ||
|
||
# Table of Contents | ||
- [Open Issues](#open-issues) | ||
- [Pre-requisites](#pre-requisites) | ||
- [Building Spark .NET on Ubuntu 18.04](#building-spark-net-on-ubuntu-1804) | ||
- [Table of Contents](#table-of-contents) | ||
- [Open Issues:](#open-issues) | ||
- [Pre-requisites:](#pre-requisites) | ||
- [Building](#building) | ||
- [Building Spark .NET Scala Extensions Layer](#building-spark-net-scala-extensions-layer) | ||
- [Building .NET Sample Applications using .NET Core CLI](#building-net-sample-applications-using-net-core-cli) | ||
- [Building .NET Sample Applications using .NET 8 CLI](#building-net-sample-applications-using-net-8-cli) | ||
- [Run Samples](#run-samples) | ||
|
||
# Open Issues: | ||
|
@@ -16,7 +18,7 @@ Building Spark .NET on Ubuntu 18.04 | |
|
||
If you already have all the pre-requisites, skip to the [build](ubuntu-instructions.md#building) steps below. | ||
|
||
1. Download and install **[.NET 6 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/6.0)** - installing the SDK will add the `dotnet` toolchain to your path. | ||
1. Download and install **[.NET 8 SDK](https://dotnet.microsoft.com/en-us/download/dotnet/8.0)** - installing the SDK will add the `dotnet` toolchain to your path. | ||
2. Install **[OpenJDK 8](https://openjdk.java.net/install/)** | ||
- You can use the following command: | ||
```bash | ||
|
@@ -110,65 +112,66 @@ Let us now build the Spark .NET Scala extension layer. This is easy to do: | |
|
||
``` | ||
cd src/scala | ||
mvn clean package | ||
mvn clean package | ||
``` | ||
You should see JARs created for the supported Spark versions: | ||
* `microsoft-spark-2-3/target/microsoft-spark-2-3_2.11-<version>.jar` | ||
* `microsoft-spark-2-4/target/microsoft-spark-2-4_2.11-<version>.jar` | ||
* `microsoft-spark-3-0/target/microsoft-spark-3-0_2.12-<version>.jar` | ||
* `microsoft-spark-3-0/target/microsoft-spark-3-5_2.12-<version>.jar` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3-5 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, I'll fix in the next PR |
||
|
||
## Building .NET Sample Applications using .NET 6 CLI | ||
## Building .NET Sample Applications using .NET 8 CLI | ||
|
||
1. Build the Worker | ||
```bash | ||
cd ~/dotnet.spark/src/csharp/Microsoft.Spark.Worker/ | ||
dotnet publish -f net6.0 -r linux-x64 | ||
dotnet publish -f net8.0 -r linux-x64 | ||
``` | ||
<details> | ||
<summary>📙 Click to see sample console output</summary> | ||
|
||
```bash | ||
user@machine:/home/user/dotnet.spark/src/csharp/Microsoft.Spark.Worker$ dotnet publish -f net6.0 -r linux-x64 | ||
user@machine:/home/user/dotnet.spark/src/csharp/Microsoft.Spark.Worker$ dotnet publish -f net8.0 -r linux-x64 | ||
Microsoft (R) Build Engine version 16.0.462+g62fb89029d for .NET Core | ||
Copyright (C) Microsoft Corporation. All rights reserved. | ||
|
||
Restore completed in 36.03 ms for /home/user/dotnet.spark/src/csharp/Microsoft.Spark.Worker/Microsoft.Spark.Worker.csproj. | ||
Restore completed in 35.94 ms for /home/user/dotnet.spark/src/csharp/Microsoft.Spark/Microsoft.Spark.csproj. | ||
Microsoft.Spark -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark/Debug/netstandard2.0/Microsoft.Spark.dll | ||
Microsoft.Spark.Worker -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net6.0/linux-x64/Microsoft.Spark.Worker.dll | ||
Microsoft.Spark.Worker -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net6.0/linux-x64/publish/ | ||
Microsoft.Spark.Worker -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net8.0/linux-x64/Microsoft.Spark.Worker.dll | ||
Microsoft.Spark.Worker -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net8.0/linux-x64/publish/ | ||
``` | ||
|
||
</details> | ||
|
||
2. Build the Samples | ||
```bash | ||
cd ~/dotnet.spark/examples/Microsoft.Spark.CSharp.Examples/ | ||
dotnet publish -f net6.0 -r linux-x64 | ||
dotnet publish -f net8.0 -r linux-x64 | ||
``` | ||
<details> | ||
<summary>📙 Click to see sample console output</summary> | ||
|
||
```bash | ||
user@machine:/home/user/dotnet.spark/examples/Microsoft.Spark.CSharp.Examples$ dotnet publish -f net6.0 -r linux-x64 | ||
user@machine:/home/user/dotnet.spark/examples/Microsoft.Spark.CSharp.Examples$ dotnet publish -f net8.0 -r linux-x64 | ||
Microsoft (R) Build Engine version 16.0.462+g62fb89029d for .NET Core | ||
Copyright (C) Microsoft Corporation. All rights reserved. | ||
|
||
Restore completed in 37.11 ms for /home/user/dotnet.spark/src/csharp/Microsoft.Spark/Microsoft.Spark.csproj. | ||
Restore completed in 281.63 ms for /home/user/dotnet.spark/examples/Microsoft.Spark.CSharp.Examples/Microsoft.Spark.CSharp.Examples.csproj. | ||
Microsoft.Spark -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark/Debug/netstandard2.0/Microsoft.Spark.dll | ||
Microsoft.Spark.CSharp.Examples -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net6.0/linux-x64/Microsoft.Spark.CSharp.Examples.dll | ||
Microsoft.Spark.CSharp.Examples -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net6.0/linux-x64/publish/ | ||
Microsoft.Spark.CSharp.Examples -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net8.0/linux-x64/Microsoft.Spark.CSharp.Examples.dll | ||
Microsoft.Spark.CSharp.Examples -> /home/user/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net8.0/linux-x64/publish/ | ||
``` | ||
|
||
</details> | ||
|
||
# Run Samples | ||
|
||
Once you build the samples, you can use `spark-submit` to submit your .NET 6 apps. Make sure you have followed the [pre-requisites](#pre-requisites) section and installed Apache Spark. | ||
Once you build the samples, you can use `spark-submit` to submit your .NET 8 apps. Make sure you have followed the [pre-requisites](#pre-requisites) section and installed Apache Spark. | ||
|
||
1. Set the `DOTNET_WORKER_DIR` or `PATH` environment variable to include the path where the `Microsoft.Spark.Worker` binary has been generated (e.g., `~/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net6.0/linux-x64/publish`) | ||
2. Open a terminal and go to the directory where your app binary has been generated (e.g., `~/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net6.0/linux-x64/publish`) | ||
1. Set the `DOTNET_WORKER_DIR` or `PATH` environment variable to include the path where the `Microsoft.Spark.Worker` binary has been generated (e.g., `~/dotnet.spark/artifacts/bin/Microsoft.Spark.Worker/Debug/net8.0/linux-x64/publish`) | ||
2. Open a terminal and go to the directory where your app binary has been generated (e.g., `~/dotnet.spark/artifacts/bin/Microsoft.Spark.CSharp.Examples/Debug/net8.0/linux-x64/publish`) | ||
3. Running your app follows the basic structure: | ||
```bash | ||
spark-submit \ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For pr pipeline - we don't define it