New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect deserialization of CBOR CIDs #163

Merged

drasticactions merged 1 commit into drasticactions:develop from alnkesq:develop

Jan 16, 2025

Contributor

alnkesq commented Jan 15, 2025

Fixes #162


          Fix incorrect deserialization of CBOR CIDs

92a019f

alnkesq commented

View reviewed changes

src/FishyFlip/CborExtensions.cs

    
                                  return Cid.Read(cid);

                                  if (cid[0] != 0)

                                  {

                                      logger?.LogError("ATCid CBOR bytes should start with 0.");

Contributor Author

alnkesq Jan 15, 2025

Usually I'd throw an exception here, but I saw that the rest of this file also logs and continues on invalid data

drasticactions merged commit 15df774 into drasticactions:develop

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet