Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect deserialization of CBOR CIDs #163

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix incorrect deserialization of CBOR CIDs #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/FishyFlip/CborExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,13 @@ internal static class CborExtensions
{
case CBORType.ByteString:
var cid = obj.GetByteString();
return Cid.Read(cid);
if (cid[0] != 0)
{
logger?.LogError("ATCid CBOR bytes should start with 0.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually I'd throw an exception here, but I saw that the rest of this file also logs and continues on invalid data

return null;
}

return Cid.Read(cid.AsSpan(1).ToArray());
case CBORType.TextString:
return Cid.Decode(obj.AsString());
}
Expand Down
Loading