Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make format of Video Processing demo variables consistent, and fix typo #953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

orosoman-dstl
Copy link
Contributor

Just me being picky about spelling/consistency

@orosoman-dstl orosoman-dstl requested a review from a team as a code owner February 7, 2024 16:51
@orosoman-dstl orosoman-dstl requested review from sdhiscocks and hpritchett-dstl and removed request for a team February 7, 2024 16:51
@sdhiscocks
Copy link
Member

You'll also need to updated ipynb and RST file, and update MD5 hash, in order for docs to build correctly. See #635 for example PR that's done this before.

@mharris-dstl mharris-dstl self-assigned this Feb 16, 2024
@mharris-dstl mharris-dstl removed their assignment Feb 16, 2024
Copy link
Contributor

@mharris-dstl mharris-dstl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, didn't see above comments.

@orosoman-dstl
Copy link
Contributor Author

Hopefully now fixed. Some weird things have happened with the ipynb diff though, hopefully not important.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa56a94) 93.24% compared to head (53e41ac) 93.24%.
Report is 58 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files         201      201           
  Lines       12617    12617           
  Branches     2589     2589           
=======================================
  Hits        11765    11765           
  Misses        602      602           
  Partials      250      250           
Flag Coverage Δ
integration 66.62% <ø> (-0.02%) ⬇️
unittests 88.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants