-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Pro Free Trials Experiment #5686
Merged
nalcalag
merged 16 commits into
develop
from
feature/noelia/free_trial_experiment_cohorts
Mar 1, 2025
Merged
Privacy Pro Free Trials Experiment #5686
nalcalag
merged 16 commits into
develop
from
feature/noelia/free_trial_experiment_cohorts
Mar 1, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
018dcf9
to
cba287e
Compare
cba287e
to
1a9b61e
Compare
…d SubscriptionSettings screen accordingly
1a9b61e
to
31ddc53
Compare
Task/Issue URL: ### Description ### Steps to test this PR _Feature 1_ - [ ] - [ ] ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)|
lmac012
reviewed
Feb 28, 2025
...in/java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialPrivacyProMetricsPixelPlugin.kt
Show resolved
Hide resolved
...pl/src/main/java/com/duckduckgo/subscriptions/impl/freetrial/FreeTrialExperimentDataStore.kt
Outdated
Show resolved
Hide resolved
…subscriptions/impl/freetrial/FreeTrialExperimentDataStore.kt Co-authored-by: Lukasz Macionczyk <[email protected]>
lmac012
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208886381764923
Description
Free Trial experiment implementation
Steps to test this PR
Pre steps
https://jsonblob.com/api/1339653006785961984
which has the experiment available- If you want the treatment variant to be always assigned, change the weight of the control cohort to 0 for
privacyProFreeTrialJan25
feature.- If you want the control variant to be always assigned, change the weight of the treatment cohort to 0 for
privacyProFreeTrialJan25
feature.Privacy Pro ROW
Control cohort (US)
experiment_enroll_privacyProFreeTrialJan25_control
is firedTreatment cohort (US)
experiment_enroll_privacyProFreeTrialJan25_treatment
is firedPixel sent: experiment_metrics_privacyProFreeTrialJan25_treatment with params: {metric=paywallImpressions, value=1..
is firedexperiment_metrics_privacyProFreeTrialJan25_treatment with params: {metric=startClickedMonthly..
is firedexperiment_metrics_privacyProFreeTrialJan25_treatment with params: {metric=subscriptionStartedMonthly...
is firedUI changes