Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Duck Player Custom Error #3970

Closed
wants to merge 7 commits into from
Closed

Conversation

mgurgel
Copy link
Collaborator

@mgurgel mgurgel commented Feb 14, 2025

Task/Issue URL: https://app.asana.com/0/1206594217596623/1209151829557390

Description:

Shows a custom error screen when Duck Player detects an error message in the YouTube embed

Steps to test this PR:

  1. In the debug menu, override privacy config to https://www.jsonblob.com/api/jsonBlob/1339986121966411776
  2. Follow the steps here: https://app.asana.com/0/1142021229838617/1209392401656236

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@mgurgel
Copy link
Collaborator Author

mgurgel commented Feb 17, 2025

Closed in favor of duckduckgo/apple-browsers#23

@mgurgel mgurgel closed this Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant