Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll area active sparkle #10539

Merged
merged 18 commits into from
Feb 5, 2025
Merged

Scroll area active sparkle #10539

merged 18 commits into from
Feb 5, 2025

Conversation

Duncid
Copy link
Contributor

@Duncid Duncid commented Feb 5, 2025

Description

  • Updating scrollArea component with the capacity to customize style when scrolling

Tests

n/a

Risk

n/a

Deploy Plan

merge & deploy

@Duncid Duncid requested a review from JulesBelveze February 5, 2025 00:21
@Duncid
Copy link
Contributor Author

Duncid commented Feb 5, 2025

@JulesBelveze created a Sparkle focused PR here.

I'm not sure how to do:

Basically having the state set to active only when the user is scrolling

But feel free to step in!

@JulesBelveze
Copy link
Contributor

@Duncid I've picked up your styling and port them this PR #10544. Let me know what you think, and feel free to tweak 👌🏼

@Duncid Duncid merged commit 87eec07 into main Feb 5, 2025
6 checks passed
@Duncid Duncid deleted the scrollAreaActiveSparkle branch February 5, 2025 15:52
@JulesBelveze JulesBelveze restored the scrollAreaActiveSparkle branch February 6, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants