[sparkle] - enh(ScrollArea): active state #10544
Open
+173
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace bespoke styling with `cva` to standardize variant management - Introduce `appearance` variant with default and unstyled options - Streamline props by removing unused callback functions - Enhance scrollbar visibility and interactivity with new hover effects
…stories - Removed the state management and conditional shadow styling based on scroll position in `SheetContainer` - Simplified scroll area styling by removing dynamic border and shadow effects in `ScrollWithActiveState` story
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at enhancing the
ScrollAreacomponent to feature an "active" state. It picks up work from #10539 and tweaks the state to be synchronized with theScrollbarleveraging the group class from tailwind.Risk
Low, no breaking changes introduced
Deploy Plan