This repository was archived by the owner on Nov 28, 2022. It is now read-only.
feat: 2647.2 add secure template repos to pfe #2747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalle61
requested review from
elsony,
hhellyer,
stalleyj and
tobespc
as code owners
rwalle61
force-pushed
the
2647.2-add-secure-template-repos-to-pfe
branch
2 times, most recently
from
aaa0848 to
3bcc568
Compare
Codecov Report
@@ Coverage Diff @@
## master #2747 +/- ##
==========================================
- Coverage 60.51% 60.48% -0.04%
==========================================
Files 102 102
Lines 10318 10304 -14
Branches 1739 1739
==========================================
- Hits 6244 6232 -12
+ Misses 4074 4072 -2
Continue to review full report at Codecov.
|
rwalle61
force-pushed
the
2647.2-add-secure-template-repos-to-pfe
branch
from
b026283 to
4eac971
Compare
added 3 commits
April 23, 2020 14:12
Signed-off-by: Richard Waller <[email protected]>
Signed-off-by: Richard Waller <[email protected]>
Signed-off-by: Richard Waller <[email protected]>
rwalle61
force-pushed
the
2647.2-add-secure-template-repos-to-pfe
branch
from
4eac971 to
dbabda5
Compare
hhellyer
suggested changes
Apr 23, 2020
added 2 commits
April 24, 2020 10:13
Signed-off-by: Richard Waller <[email protected]>
Signed-off-by: Richard Waller <[email protected]>
2 tasks
hhellyer
approved these changes
Apr 24, 2020
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this ?
What does this PR do ?
Extends PFE's
POST /templates/repositoriesto accept GHE repos if we providegitCredentials(username & password) in the request body. See theopenapi.yamland the API tests for more details.Currently if we successfully add a secure template, then subsequent calls to
GET /templates/repositoriesandGET /templateswill show the secure repo and its templates respectively. i.e. we do not check whether the credentials are still validWe also do not currently encrypt the credentials in the request body, meaning they get logged on
tracelog level. We will need a solution for that in futureI had to do some refactoring to get my changes in but the tests should cover my changes ~100%
Which issue(s) does this PR fix ?
part 2 of #2647
Does this PR require a documentation change ?
2647 will require documentation changes
Any special notes for your reviewer ?
To run the tests you will need to input your own GHE credentials