feat: dataspace protocol negotiation transformer #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliapampus
added
enhancement
juliapampus
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...edc.protocol.dsp.negotiation.transform/to/JsonObjectToContractRequestMessageTransformer.java
Fixed
Show fixed
Hide fixed
...c.protocol.dsp.negotiation.transform/to/JsonObjectToContractAgreementMessageTransformer.java
Fixed
Show fixed
Hide fixed
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
+ Coverage 64.79% 64.91% +0.12%
==========================================
Files 953 965 +12
Lines 19561 19754 +193
Branches 1169 1178 +9
==========================================
+ Hits 12674 12824 +150
- Misses 6434 6471 +37
- Partials 453 459 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
68f35e7
to
2e8192d
Compare
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
2e8192d
to
b39c129
Compare
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
b39c129
to
e05ee9e
Compare
|
Open question: How to set |
...ava/org.eclipse.edc.protocol.dsp.negotiation.transform/DspNegotiationTransformExtension.java
Outdated
Show resolved
Hide resolved
...ava/org.eclipse.edc.protocol.dsp.negotiation.transform/DspNegotiationTransformExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Apr 20, 2023
There was a problem hiding this comment.
pretty much ok, apart from that potential bug in JsonObjectToContractNegotiationEventMessageTransformer, we should remove the side effect from transformString and make it return the string instead of evaluating a function passed.
Maybe first adding a new method, to avoid bloating this PR.
...otocol.dsp.negotiation.transform/from/JsonObjectFromContractAgreementMessageTransformer.java
Outdated
Show resolved
Hide resolved
...se.edc.protocol.dsp.negotiation.transform/from/JsonObjectFromContractRequestTransformer.java
Outdated
Show resolved
Hide resolved
...c.protocol.dsp.negotiation.transform/to/JsonObjectToContractAgreementMessageTransformer.java
Outdated
Show resolved
Hide resolved
...col.dsp.negotiation.transform/to/JsonObjectToContractNegotiationEventMessageTransformer.java
Outdated
Show resolved
Hide resolved
...col.dsp.negotiation.transform/to/JsonObjectToContractNegotiationEventMessageTransformer.java
Outdated
Show resolved
Hide resolved
...edc.protocol.dsp.negotiation.transform/to/JsonObjectToContractRequestMessageTransformer.java
Outdated
Show resolved
Hide resolved
data-protocols/dsp/dsp-negotiation/dsp-negotiation-transform/build.gradle.kts
Outdated
Show resolved
Hide resolved
7 tasks
7 tasks
jimmarino
approved these changes
Apr 20, 2023
data-protocols/dsp/dsp-negotiation/dsp-negotiation-spi/build.gradle.kts
Outdated
Show resolved
Hide resolved
...egotiation.transform/from/JsonObjectFromContractAgreementVerificationMessageTransformer.java
Outdated
Show resolved
Hide resolved
...dsp.negotiation.transform/from/JsonObjectFromContractNegotiationEventMessageTransformer.java
Outdated
Show resolved
Hide resolved
...col.dsp.negotiation.transform/to/JsonObjectToContractNegotiationEventMessageTransformer.java
Outdated
Show resolved
Hide resolved
...p.negotiation.transform/to/JsonObjectToContractNegotiationTerminationMessageTransformer.java
Outdated
Show resolved
Hide resolved
7 tasks
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
e39de4a
to
1366240
Compare
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
1366240
to
ca0292d
Compare
juliapampus
force-pushed
the
feat/dsp-negotiation-transform
branch
from
ed166dc
to
9c73f2d
Compare
ndr-brt
approved these changes
Apr 26, 2023
| @@ -17,5 +17,4 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
There was a problem hiding this comment.
the whole dependencies block can be removed
…jectionReason (spec)
janpmeyer
force-pushed
the
feat/dsp-negotiation-transform
branch
from
364b1f1
to
c1c79d7
Compare
majadlymhmd
pushed a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
May 10, 2023
--------- Co-authored-by: Jan Peter Meyer <[email protected]> Co-authored-by: Ronja Quensel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements contract negotiation spi and transformers:
:data-protocols:dsp:dsp-negotiation:dsp-negotiation-spi:data-protocols:dsp:dsp-negotiation:dsp-negotiation-transformspec alignments:
callbackinContractAgreementMessageContractNegotiationEventMessagecodeinContractNegotiationTerminationMessagerejectionReasoninContractNegotiationTerminationMessagecontractStartandcontractEndinContractOffer, see feat: implement policies for contract start/end date #2758checksumtoContractNegotiationWhy it does that
Support the dataspace protocol specification.
Further notes
Derived issue #2775.
Linked Issue(s)
Relates #2474
Closes #2764
Checklist
no-changelog)