-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Assume new equinox.binaries repo name by default in scripts #641
[Build] Assume new equinox.binaries repo name by default in scripts #641
Conversation
6a00839
to
813c57a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Launcher test now fail
|
813c57a
to
17652d7
Compare
When this is submitted we should also adapt the paths in and all other references the releng.aggregator repository. |
Adapt to the name changed assumption about the default name in equinox. See eclipse-equinox/equinox#641
Adapt to the name changed assumption about the default name in equinox. See eclipse-equinox/equinox#641
This is now done with eclipse-platform/eclipse.platform.releng.aggregator#2128. |
08602b7
to
70ee8f5
Compare
Because the repository containing the Equinox binaries is now named 'eclipse-equinox/equinox.binaries' its folder is, by default, named 'equinox.binaries' after cloning it. In order to simplify contributions that name should be assumed by default. Accordingly rename the property 'rt.equinox.binaries.loc' used in the build to 'equinox.binaries.loc'.
70ee8f5
to
f50795c
Compare
Finally the build is green (besides the usual TCK failure), so lets submit this. |
Adapt to the name changed assumption about the default name in equinox. See eclipse-equinox/equinox#641
Adapt to the name changed assumption about the default name in equinox. See eclipse-equinox/equinox#641
Because the repository containing the Equinox binaries is now named 'eclipse-equinox/equinox.binaries' its folder is, by default, named 'equinox.binaries' after cloning it.
In order to simplify contributions that name should be assumed by default.
Accordingly rename the property 'rt.equinox.binaries.loc' used in the build to 'equinox.binaries.loc'.
@tjwatson do you have any objections?