-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move filters Button in Call Hierarchy view to the top level Bar #1671
Conversation
1557309
to
905cd5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jannisCode thank you for the contribution, it looks good and works as expected!
I have some minor change requests though, mostly regarding new lines but the important one is about extracting the internal class org.eclipse.jdt.internal.ui.callhierarchy.CallHierarchyFiltersActionGroup.ShowFilterDialogAction
in order to reduce code duplication.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyViewPart.java
Outdated
Show resolved
Hide resolved
905cd5a
to
d9964df
Compare
...pse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/CallHierarchyFiltersActionGroup.java
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/ShowFilterDialogAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/ShowFilterDialogAction.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/ShowFilterDialogAction.java
Outdated
Show resolved
Hide resolved
8512f00
to
8c1c2f9
Compare
109872e
to
5c6bf32
Compare
6a2061f
to
64e52b6
Compare
@jannisCode regarding this build error:
It seems that the |
64e52b6
to
2f07868
Compare
Thank you for addressing my change request @jannisCode . The PR looks good for me but since I'm not a committer, I can't merge it. Maybe some committer (@jjohnstn / @vogella?) wants to take a look and let the workflows run before reviewing/merging? |
- Added class FiltersAction - Added fFiltersAction to CallHierarchyViewPart to create an icon in the top level bar - changed the constructor of FiltersAction so that the picture and Text are the same as in the View Menu - Connected the icon to its functionality by adding a method called openFiltersDialog which opens the pop up window for the filters
2f07868
to
ec21387
Compare
@fedejeanne I'm not a JDT committer |
@fedejeanne I'll look at it today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (all of @fedejeanne comments have been addressed) and works fine.
Hi @jannisCode Thank you for the patch. |
After a pull, my IDE now has this error: Indeed it was incremented 4 weeks ago: I don't think we can undo the damage after this has been pulled into an I-Build. |
@merks thank you for reporting it. Do you know why was this not reported by the (GH) builds? I noticed the same error locally when trying to fix the build in this PR but I thought it might be a false positive in my IDE. Increasing the version fixed the PR-builds. More details in my discussion (I'd like to continue the discussion there): eclipse-platform/eclipse.platform.releng.aggregator#2406 |
What it does
Before the changes the filters could only be accessed through the "View Menu" (three dots), which is inconvenient considering that the filters button is rather important and frequently used.
After the changes the filters can be accessed by clicking on the icon in the top level bar as well as the old way through the view menu.
Before
After
Author checklist