-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show only tests #1687
Show only tests #1687
Conversation
39bc6b6
to
4612df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution, @jannisCode!
I tested the changes and they produce the expected output ✔️
I only have some comments regarding formatting and unnecessary code. Once that is addressed, you can set this PR as "ready to review" so the community can also look at it.
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Outdated
Show resolved
Hide resolved
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Outdated
Show resolved
Hide resolved
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Outdated
Show resolved
Hide resolved
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Show resolved
Hide resolved
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchy.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchy.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchy.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
4612df6
to
05814a0
Compare
...lipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchy.java
Outdated
Show resolved
Hide resolved
...pulation/core extension/org/eclipse/jdt/internal/corext/callhierarchy/CallHierarchyCore.java
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
e71a95e
to
f340d19
Compare
@jannisCode I think the last amend changed the commit message. The commit message should follow these guidelines: https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md#commit_message_recommendations |
f340d19
to
4ae21fa
Compare
4ae21fa
to
1e6e31a
Compare
@@ -37,10 +37,14 @@ | |||
import org.eclipse.jdt.internal.ui.util.StringMatcher; | |||
|
|||
public class CallHierarchy { | |||
private static final String PREF_USE_IMPLEMENTORS= "PREF_USE_IMPLEMENTORS"; //$NON-NLS-1$ | |||
|
|||
private static final String PREF_SHOW_ALL_CODE = "PREF_SHOW_ALL_CODE"; //$NON-NLS-1$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these constants copy the values from CallHierarchyCore.java? Is it important that the values are the same? Then please reuse it (declare package x-friend).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In CallHierarchyCore I changed the three constants which I added to public and will create another PR for the three constants which have already been there when I started the issue and are also private.
In the other PR I will make them Public and change the code in CallHierarchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
480f294
to
570bf79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it works. I only have 2 nit-picky suggestions on how to make the code more compact.
After that, it's good to go on my side.
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/callhierarchy/FiltersDialog.java
Show resolved
Hide resolved
changed the feature from only one selectable option to three radio buttons which are more understandable and provide more functionality.
04b239a
to
1879246
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected and all comments (mine and @jukzi's) have been addressed.
Could you please merge this one too, @jukzi ? I don't have any committer rights on JDT :-) |
@jukzi I think this is "noteworthy", what do you say? Should @jannisCode create an N&N entry? |
Ok
Jörg Kubitz
… Am 15.10.2024 um 15:20 schrieb Federico Jeanne ***@***.***>:
@jukzi I think this is "noteworthy", what do you say?
Should @jannisCode create an N&N entry?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
What it does
Add a new option to only show the test code when filtering the Call Hierarchy. The option was missing before since one could only either show all code or show only non-test code.
Before
After
Author checklist