-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing the visability Constants in the CallHierarchy #1706
Conversation
@@ -60,25 +56,25 @@ public static CallHierarchy getDefault() { | |||
public boolean isSearchUsingImplementorsEnabled() { | |||
IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore(); | |||
|
|||
return settings.getBoolean(PREF_USE_IMPLEMENTORS); | |||
return settings.getBoolean(CallHierarchyCore.PREF_USE_IMPLEMENTORS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static import CallHierarchyCore.* instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better all 4 static imports since org.eclipse.jdt.ui.staticondemandthreshold=99
(in org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.ui.prefs
)
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_FILTERS_LIST;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_FILTER_TESTCODE;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_FILTERS;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_IMPLEMENTORS;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have imported all 6 constants to callHierarchy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the static imports are added and the usages of the constants in CallHierarchy
are adapted (i.e. remove the unnecessary CallHierarchyCore
from the usages), this PR is good to go on my account.
755d1b5
to
46bb287
Compare
resolve the merge conflict, please |
46bb287
to
2f5bbd3
Compare
2f5bbd3
to
928979d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jukzi could you please merge this one? :-)
What it does
It does not have any effect on the functionality, but it addresses and completes the suggestion from @jukzi which he made here: (#1687)
Because the constants of which the visability is changed here are not part of PR #1687 , this PR is aimed at completing the suggestion made there.
Author checklist