Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oomph-Setup] Add jdt.ui configuration setup #1710

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

HannesWell
Copy link
Contributor

What it does

Add jdt.ui configuration setup.
Additionally add a styled and drag&drop-able Oomph Configuration button to the main README.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430

This currently depends on #1707 respectively contains the changed proposed there!

Author checklist

@HannesWell
Copy link
Contributor Author

HannesWell commented Oct 11, 2024

This currently depends on #1707 respectively contains the changed proposed there! Therefore I suggest to submit that first.

Additionally add a styled and drag&drop-able Oomph Configuration button
to the main README.

Part of eclipse-platform/eclipse.platform.releng.aggregator#2430
@HannesWell
Copy link
Contributor Author

This currently depends on #1707 respectively contains the changed proposed there! Therefore I suggest to submit that first.

I have now refactored this PR to not depend on #1707 so this can be submitted immediately.

@jukzi or @iloveeclipse, could you please submit this as well? Thanks in advance.

@jukzi
Copy link
Contributor

jukzi commented Oct 11, 2024

probably unrelated: baseline and build for org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessorUtil.class have different contents have never seen such build error before.

@HannesWell
Copy link
Contributor Author

probably unrelated: baseline and build for org/eclipse/jdt/internal/ui/text/correction/QuickAssistProcessorUtil.class have different contents have never seen such build error before.

Yes this change should not have any effect on the compilation or build results at all.

@merks
Copy link
Contributor

merks commented Oct 11, 2024

Definitely the setups are invisible to the build. Best to get this merged so we get the setups in a consistent state again.

@merks
Copy link
Contributor

merks commented Oct 11, 2024

If we can just get this committed, the setup-archiver will be ultra-happy again:

image

@iloveeclipse iloveeclipse merged commit 5b3e309 into eclipse-jdt:master Oct 11, 2024
6 of 10 checks passed
@HannesWell HannesWell deleted the oomph-configuration branch October 11, 2024 21:31
@HannesWell
Copy link
Contributor Author

Thank you Andrey for submitting!

The result again looks good and as expected:
grafik

The installer website for JDT UI looks also good:
https://www.eclipse.org/setups/installer/?url=https://raw.githubusercontent.com/eclipse-jdt/eclipse.jdt.ui/master/org.eclipse.jdt.ui.setup/JdtUIConfiguration.setup&show=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants