WIP: Accelerate Unsafe CAS Intrinsics on Z #20308
Conversation
Adds support for the following recognized methods: CompareAndExchangeObject //JDK11 CompareAndExchangeReference //JDK17,21 CompareAndExchangeInt //JDK11,17,21 CompareAndExchangeLong //JDK11,17,21 The accelerated CAE code was built on top of the existing accelerated CAS support on Z. Changes are similar to previously added support on Power and X. Signed-off-by: jimmyk <[email protected]>
|
This is marked WIP while I get finish running through all the unit tests I wrote. But all the tests for major functionality are passing so far so I don't expect any major changes. @hzongaro Could you take a look at this. The common changes are small in an area you've looked at recently so it should be fairly quick. @r30shah Could you look over the Z codegen changes? Everything seems to work but I don't work when Z codegen often so I might have missed smaller details. |
| return true; | ||
| } | ||
| } | ||
| // Too risky to do Long-31bit version now. |
There was a problem hiding this comment.
We should move this comment close to where we only do the transformation for 64-bit.
There was a problem hiding this comment.
I'm not exactly sure when you want me to move this. The comment is right after the block with the comp->target().is64Bit() check.
There was a problem hiding this comment.
I think right before the condition for 64-bit would be the appropriate place. I would not have thought of else part for 31-bit.
Adds support for the following recognized methods:
The accelerated CAE code was built on top of the existing accelerated CAS support on Z. Changes are similar to previously added support on Power and X.
Edit:
Depends on: eclipse/omr#7482
Ideally merged as a pair.