Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Accelerate Unsafe CAS Intrinsics on Z #7482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IBMJimmyk
Copy link
Contributor

@IBMJimmyk IBMJimmyk commented Oct 6, 2024

Support for acceleration of compareAndExchange[Int|Long|Reference] has been extended to Z. As a result, the check in
callDoesAnImplicitAsyncCheck needs to be updated as well.

Edit:
Should be checked in before: eclipse-openj9/openj9#20308
Ideally merged as a pair.

Support for acceleration of compareAndExchange[Int|Long|Reference] has
been extended to Z. As a result, the check in
callDoesAnImplicitAsyncCheck needs to be updated as well.

Signed-off-by: jimmyk <[email protected]>
@IBMJimmyk
Copy link
Contributor Author

This is marked WIP while I get finish running through all the unit tests I wrote. But all the tests for major functionality are passing so far so I don't expect any major changes.

@hzongaro Could you take a look at this. It's a small change in an area you've looked at recently so it should be fairly quick.

Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change looks good.

@hzongaro
Copy link
Member

hzongaro commented Oct 7, 2024

Part of a pair with: eclipse-openj9/openj9#20308
I don't think they need to be delivered at the same time.

Actually, I think this one will need to be merged and promoted before eclipse-openj9/openj9#20308 can be merged. Otherwise, there's a risk that asyncchecks will still be removed as redundant even after the JIT begins generating inline IL on z replacing the calls to Unsafe.compareAndExchange* methods.

@IBMJimmyk
Copy link
Contributor Author

That makes sense. I've updated the opening post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants