Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash: Integrate DASH tool in Bazel build #155

Closed
wants to merge 1 commit into from
Closed

dash: Integrate DASH tool in Bazel build #155

wants to merge 1 commit into from
+440 −0

Conversation

nradakovic
Copy link
Member

@nradakovic nradakovic commented Jan 13, 2025 •
edited
Loading

This PR adds support for the DASH tool within the S-CORE Bazel build system. The integration includes:

  • Defining custom Bazel rules to handle the DASH tool's setup and execution.
  • Adding necessary dependencies in BUILD files to ensure compatibility with existing project requirements.
  • Validating the integration with the current CI pipeline to maintain a seamless build and deployment process.

This enhancement simplifies the workflow by consolidating tools into the Bazel build system, improving build automation and traceability.

Issue-ref: see #126

@nradakovic nradakovic force-pushed the nira_dash_integration branch 4 times, most recently from 6f9fd0f to f9b72be Compare January 13, 2025 20:09
@nradakovic
dash: Integrate DASH tool in Bazel build
cf96667 
This commit adds support for the DASH tool within the S-CORE Bazel build system.
The integration includes:

- Defining custom Bazel rules to handle the DASH tool's setup and execution.
- Adding necessary dependencies in BUILD files to ensure compatibility with
  existing project requirements.
- Validating the integration with the current CI pipeline to maintain a seamless build
  and deployment process.
- Updating documentation (if applicable) to reflect the addition of DASH
  in the Bazel workflow.

This enhancement simplifies the workflow by consolidating tools into the Bazel build system,
improving build automation and traceability.

Issue-ref: see eclipse-score#126
@nradakovic nradakovic force-pushed the nira_dash_integration branch from f9b72be to cf96667 Compare January 13, 2025 20:12
@nradakovic nradakovic marked this pull request as ready for review January 21, 2025 07:24
@nradakovic
Copy link
Member Author

@AlexanderLanin
Currently we cannot pass license check due to the tools used in our build tree. There are 2 options how to proceed:

  1. We integrate this now with red check;
  2. We disable execution of tool on check but we merge tool;
    Either way someone who is responsable for IP compliance will need to check the tool list used in project (taken from output of GitHub Action or by executing tool locally) and approuch Eclipse Foundation IP team with request for review of these tools.

@AlexanderLanin
Copy link
Member

AlexanderLanin commented Jan 21, 2025 •
edited
Loading

As I understand it Dash will automatically start clearance process when we provide it with a token.

Feedback kuksa:

our approach is: merge without dash release. Because they are mostly transitive dependencies or updated dependencies. IF someone DIRECTLY tunes a new dependency into a PR (i.e. a new entry in the cargo), committer manually checks whether the “claimed” license fits. Just like before. Dash is asynchronous.
The only thing we do in KUKSA: We only do a RELEASE if there is nothing more pending in Dash
I don't know if this is ok with Eclipse, but it's our “best practice” and nobody has complained yet

@AlexanderLanin AlexanderLanin added the infrastructure General Score infrastructure topics label Jan 23, 2025
@AlexanderLanin AlexanderLanin mentioned this pull request Jan 28, 2025
Open
8 tasks
@AlexanderLanin
Copy link
Member

FYI: token requested at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5590

@AlexanderLanin
Copy link
Member

As discussed a while ago, let's adapt this to run a non-failing "license check preparation" job in PRs. Should be easy enough?! And we can finally merge this!

I'll address in daily whether someone can pick this up.

This was referenced Feb 12, 2025
Closed
Open
This was referenced Feb 14, 2025
Closed
Merged
@AlexanderLanin
Copy link
Member

This PR was replaced with #378 which was just merged.

@nradakovic nradakovic deleted the nira_dash_integration branch February 18, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
infrastructure General Score infrastructure topics
Projects
Operational (Tooling/Infrastructure)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nradakovic @AlexanderLanin