Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(partnerNetwork): Get data from partner network pool by portal backend (#61) #1082

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tfjanjua
Copy link
Contributor

@tfjanjua tfjanjua commented Oct 21, 2024

Description

Developed an API in portal-backend to get data from partner-network-pool instead of calling business-partner-pool service directly from the portal-frontend.

Why

This approach will make it consistent and secure, as we are already been calling business-partner-pool service from portal-backed to get legal-entity data by BPN.

Issue

Ref: #1079

Corresponding Configuration PR

eclipse-tractusx/portal#461

Checklist

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@MaximilianHauer
Copy link

before merging/approving please look into the comment of the issue #1079

Copy link

sonarcloud bot commented Oct 22, 2024

@evegufy evegufy changed the title chore(partnerNetwork): Get data from partner network pool by portal backend (#61) feat(partnerNetwork): Get data from partner network pool by portal backend (#61) Oct 23, 2024
@evegufy evegufy added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Oct 24, 2024
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not doing anything else than mapping BpdmPartnerNetworkData to PartnerNetworkResponse. No access to portal db is done, this implements more or less a reverse proxy. From my point of view @oyo 's comment #1079 (comment) is valid and the implementation of a reverse-proxy should be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Status: IN REVIEW
Development

Successfully merging this pull request may close these issues.

4 participants