Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(administration): add bpn address for pool access in admin service #461

Conversation

tfjanjua
Copy link

Description

Developed an API in portal-backend to get data from partner-network-pool instead of calling business-partner-pool service directly from the portal-frontend.

Why

This approach will make it consistent and secure, as we are already been calling business-partner-pool service from portal-backed to get legal-entity data by BPN.

Issue

Ref: #457

Corresponding Backend PR

eclipse-tractusx/portal-backend#1082

Checklist

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@tfjanjua
Copy link
Author

Now we dont need this config, since we already have

- name: "BPNACCESS__BASEADDRESS"
   value: "{{ .Values.bpdm.poolAddress }}{{ .Values.bpdm.poolApiPath }}"

Closing this PR

@tfjanjua tfjanjua closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

1 participant