Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow special char, digits in search input of service overview #1242

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shubhamv-ss
Copy link
Contributor

@shubhamv-ss shubhamv-ss commented Oct 16, 2024

Description

  • Allow special chars, and digits in search services

Why

  • The regular expression that previously restricted search input to text-only has been removed.
  • Also, there is no validation for service names during the creation process.
  • This modification establishes consistency between the service name field in the Create Service Card and the search services functionality.
Screen.Recording.2024-10-16.at.1.27.11.PM.mov

Changelog Entry

- **Service Overview**
  - search services field should allow speacial chars, digits

Issue

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@evegufy evegufy added this to the Release 2.3.0 (24.12) milestone Oct 24, 2024
@evegufy evegufy changed the base branch from main to release/v2.3.0-RC2 October 24, 2024 18:39
@evegufy evegufy changed the base branch from release/v2.3.0-RC2 to release/v2.3.0-RC3 November 4, 2024 19:13
CHANGELOG.md Outdated
Comment on lines 5 to 8
### BugFixes

- **Service Overview**
- search services field should allow speacial chars, digits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put changelog update in PR descriptions to avoid conflicts

@manojava-gk @lavanya-bmw @kunalgaurav-bmw Please review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Please remove CHANGELOG.md changes as @evegufy requested

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Please check @lavanya-bmw

@evegufy evegufy changed the base branch from release/v2.3.0-RC3 to release/v2.3.0-RC4 November 12, 2024 17:11
@evegufy evegufy changed the base branch from release/v2.3.0-RC4 to main November 13, 2024 13:56
@evegufy
Copy link
Contributor

evegufy commented Nov 13, 2024

@manojava-gk @lavanya-bmw @kunalgaurav-bmw Please review

Copy link

sonarcloud bot commented Nov 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: IN PROGRESS
Development

Successfully merging this pull request may close these issues.

5 participants