Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow special char, digits in search input of service overview #1242

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: allow special char, digits in search input of service overview #1242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
731e160
fix: allow special char, digits in search input of service overview
shubhamv-ss Oct 16, 2024
c3770be
Merge branch 'release/v2.3.0-RC3' into fix/service-overview-search-in…
shubhamv-ss Nov 11, 2024
27f52d1
Update CHANGELOG.md
shubhamv-ss Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

### BugFixes

- **Service Overview**
- search services field should allow speacial chars, digits
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put changelog update in PR descriptions to avoid conflicts

@manojava-gk @lavanya-bmw @kunalgaurav-bmw Please review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Please remove CHANGELOG.md changes as @evegufy requested

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, Please check @lavanya-bmw


### Feature

- **Clearinghouse Self-Description**
Expand Down
5 changes: 1 addition & 4 deletions src/components/pages/ServiceReleaseProcess/components/ServiceListOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export default function ServiceListOverview() {
},
})
setPage(0)
setSearchExpr('')
}

const statusFilterViews = [
Expand Down Expand Up @@ -167,10 +168,6 @@ export default function ServiceListOverview() {

const onSearch = useCallback(
(expr: string) => {
const validateExpr = /^[ A-Za-z]*$/.test(expr)
if (!validateExpr) {
return
}
setSearchExpr(expr)
debouncedSearch(expr)
},
Expand Down
Loading