Fix/dtrcontract reusage #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-rm-meyer-ISST
requested changes
May 21, 2024
There was a problem hiding this comment.
overall works ways better. Currently for derlivery information due to an error mutliple Contracts are done. Could you please check that? Is this on purpose due to the three different types of asset cutting? If so, we should try on switching to reuse edc management of contracts (maybe we should handle that post R24.05)
...main/java/org/eclipse/tractusx/puris/backend/common/edc/logic/service/EdcAdapterService.java
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ava/org/eclipse/tractusx/puris/backend/delivery/logic/service/DeliveryRequestApiService.java
Dismissed
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/puris/backend/demand/logic/services/DemandRequestApiService.java
Dismissed
Show resolved
Hide resolved
.../java/org/eclipse/tractusx/puris/backend/stock/logic/service/ItemStockRequestApiService.java
Dismissed
Show resolved
Hide resolved
tom-rm-meyer-ISST
approved these changes
May 24, 2024
# Conflicts: # charts/puris/Chart.yaml # charts/puris/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
edited getAasSubmodelDescriptors method of EdcAdapterService to be more hesitant when invalidating contract data for the DTR asset of a partner. Invalidation now will happen only, if no response or a completely unexpected response was received
enabled the SammMapper classes to produce empty responses
solving Fix: Contracts are not reused, if no shell descriptors are found #367
edited getEdrForTransferProcessId method in order to handle unexpected responses from the edrs-API more gracefully
fixed DTR Registration workflow to deploy the known customers on first try
added/improved emergency cx-id fetch
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: