Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/add simple data backend #54

Merged
merged 13 commits into from
Apr 4, 2024
Merged

Chore/add simple data backend #54

merged 13 commits into from
Apr 4, 2024

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Mar 7, 2024 •
edited by evegufy
Loading

Description

  • Added Helm Chart for simple-data-backend
  • Added simple-data-backend Spring App
  • Added workflows to build and publish simple-data-backend as docker image

eclipse-tractusx/sig-release#418

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ds-jhartmann
Copy link
Contributor Author

As discussed with @jzbmw I'm adding the simple data backend java service to this repository

@ds-jhartmann ds-jhartmann marked this pull request as ready for review March 7, 2024 15:21
This was referenced Mar 7, 2024
Closed
Merged
almadigabor
almadigabor approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

florianrusch-zf
florianrusch-zf requested changes Mar 13, 2024
View reviewed changes
charts/simple-data-backend/values.yaml Outdated Show resolved Hide resolved
charts/simple-data-backend/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/simple-data-backend/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/simple-data-backend/templates/deployment.yaml Outdated Show resolved Hide resolved
florianrusch-zf
florianrusch-zf requested changes Mar 18, 2024
View reviewed changes
simple-data-backend/Dockerfile Outdated Show resolved Hide resolved
charts/simple-data-backend/values.yaml Show resolved Hide resolved
charts/simple-data-backend/values.yaml Show resolved Hide resolved
evegufy
evegufy requested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general! some comments and I opened #59 for pre-checks.

simple-data-backend/Dockerfile Outdated Show resolved Hide resolved
simple-data-backend/Dockerfile Outdated Show resolved Hide resolved
simple-data-backend/Dockerfile Show resolved Hide resolved
.github/workflows/build-docker-image.yaml Show resolved Hide resolved
@ds-jhartmann ds-jhartmann merged commit ae76e2f into main Apr 4, 2024
7 checks passed
@ds-jhartmann ds-jhartmann deleted the chore/add-simple-data-backend branch April 4, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianrusch-zf florianrusch-zf florianrusch-zf approved these changes

@almadigabor almadigabor almadigabor approved these changes

@evegufy evegufy evegufy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ds-jhartmann @evegufy @almadigabor @florianrusch-zf