-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support latest vsomeip and Zenoh transports #54
Merged
PLeVasseur
merged 1 commit into
eclipse-uprotocol:main
from
PLeVasseur:feature/update-zenoh-someip-transport
Nov 14, 2024
Merged
Update to support latest vsomeip and Zenoh transports #54
PLeVasseur
merged 1 commit into
eclipse-uprotocol:main
from
PLeVasseur:feature/update-zenoh-someip-transport
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
from
November 10, 2024 03:22
a2b6886
to
06a0c38
Compare
PLeVasseur
added a commit
to PLeVasseur/up-streamer-rust
that referenced
this pull request
Nov 11, 2024
Implements [#11] Implements [eclipse-uprotocol#29] Implements [eclipse-uprotocol#53]
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
from
November 11, 2024 17:17
06a0c38
to
cb8e4e2
Compare
sophokles73
reviewed
Nov 12, 2024
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
3 times, most recently
from
November 12, 2024 21:37
1081c28
to
2d70cf8
Compare
sophokles73
reviewed
Nov 13, 2024
sophokles73
reviewed
Nov 13, 2024
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
from
November 13, 2024 19:39
50bc53c
to
dbf179f
Compare
sophokles73
reviewed
Nov 14, 2024
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
from
November 14, 2024 15:28
666408e
to
a7590de
Compare
sophokles73
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
don't forget to squash ...
…ransports. Main content: * Convert up-streamer from async-std to tokio * Update tests to tokio from async-std * Ensure examples work again: * me_service <-> ue_client * ue_service <-> me_client * ue_publisher -> me_subscriber * me_publisher -> ue_subscriber Useful improvements: * Remove 'unstable' and 'internal' features of Zenoh now that no longer needed. * Modify build to allow optionally building with Zenoh and/or vsomeip. If building with both, reference streamers that use them both are then built. * Move optional dependecies' version declaration into workspace Cargo.toml, flag as optional in each package. Implements #11 Implements eclipse-uprotocol#29 Implements eclipse-uprotocol#53
PLeVasseur
force-pushed
the
feature/update-zenoh-someip-transport
branch
from
November 14, 2024 17:26
a7590de
to
556fc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Opening as draft pull request as we need to have eclipse-uprotocol/up-transport-vsomeip-rust#31 merge first.Above PR merged, so removed draft status.
Testing Status of Examples
I did a manual test of the examples to make sure that communications were flowing.