Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support latest vsomeip and Zenoh transports #54

Conversation

PLeVasseur
Copy link
Contributor

@PLeVasseur PLeVasseur commented Nov 10, 2024

Note: Opening as draft pull request as we need to have eclipse-uprotocol/up-transport-vsomeip-rust#31 merge first.

Above PR merged, so removed draft status.

Testing Status of Examples

I did a manual test of the examples to make sure that communications were flowing.

✅ or ❌
me_client <-> ue_service
ue_client <-> me_service
me_publisher -> ue_subscriber
ue_publisher -> me_subscriber

@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch from a2b6886 to 06a0c38 Compare November 10, 2024 03:22
PLeVasseur added a commit to PLeVasseur/up-streamer-rust that referenced this pull request Nov 11, 2024
@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch from 06a0c38 to cb8e4e2 Compare November 11, 2024 17:17
@PLeVasseur PLeVasseur marked this pull request as ready for review November 11, 2024 17:58
example-streamer-uses/Cargo.toml Outdated Show resolved Hide resolved
up-linux-streamer-plugin/Cargo.toml Outdated Show resolved Hide resolved
up-linux-streamer/Cargo.toml Outdated Show resolved Hide resolved
up-streamer/src/ustreamer.rs Show resolved Hide resolved
@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch 3 times, most recently from 1081c28 to 2d70cf8 Compare November 12, 2024 21:37
@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch from 50bc53c to dbf179f Compare November 13, 2024 19:39
.github/workflows/unbundled-lint-and-test.yaml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
example-streamer-uses/Cargo.toml Outdated Show resolved Hide resolved
example-streamer-uses/Cargo.toml Outdated Show resolved Hide resolved
@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch from 666408e to a7590de Compare November 14, 2024 15:28
Copy link

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

don't forget to squash ...

…ransports.

Main content:

* Convert up-streamer from async-std to tokio
* Update tests to tokio from async-std
* Ensure examples work again:
  * me_service <-> ue_client
  * ue_service <-> me_client
  * ue_publisher -> me_subscriber
  * me_publisher -> ue_subscriber

Useful improvements:

* Remove 'unstable' and 'internal' features of Zenoh now that no longer needed.
* Modify build to allow optionally building with Zenoh and/or vsomeip. If building with both, reference streamers that use them both are then built.
* Move optional dependecies' version declaration into workspace Cargo.toml, flag as optional in each package.

Implements #11
Implements eclipse-uprotocol#29
Implements eclipse-uprotocol#53
@PLeVasseur PLeVasseur force-pushed the feature/update-zenoh-someip-transport branch from a7590de to 556fc9f Compare November 14, 2024 17:26
@PLeVasseur PLeVasseur merged commit 7f2c2b6 into eclipse-uprotocol:main Nov 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants