ZenohUTransport implementaton #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmedd
added a commit
to gregmedd/up-transport-zenoh-cpp
that referenced
this pull request
Jun 27, 2024
Checking changes in eclipse-uprotocol#64 enable eclipse-uprotocol#54 to proceed Merge remote-tracking branch 'sasha/zenoh-utransport-impl' into check/add-zenohcpp-conan
|
@sashacmc - #64 has been merged and confirmed working with zenoh-cpp. Two steps will be needed to update this PR to pull in those changes:
The patch makes a few small changes that will enable the code on this branch to build. |
sashacmc
force-pushed
the
zenoh-utransport-impl
branch
from
a1c58c0
to
d1f577a
Compare
|
@sashacmc - we have diverged from the PR. I am planning on merging our branch as a foundation for continued work. Our branch contains the entirety of this PR (as of last week) with some changes on top of that. I did squash these commits, but made sure to retain attribution of the work. Would it be ok with you if I close this PR and merge our draft branch? I have a little clean-up left to do and one more commit to roll in to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51