Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching dependencies to zenohcpp #64

Merged

Conversation

gregmedd
Copy link
Contributor

The new implementation will use the C++ Zenoh library instead of the C library.

This is related to eclipse-uprotocol/up-conan-recipes#12

Publishing in draft state until eclipse-uprotocol/up-conan-recipes#13 is merged.

The new implementation will use the C++ Zenoh library instead of the C
library.
@gregmedd gregmedd self-assigned this Jun 27, 2024
@gregmedd gregmedd added this to the alpha.2 milestone Jun 27, 2024
Copy link

@BishrutSubedi BishrutSubedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gregmedd added a commit to gregmedd/up-transport-zenoh-cpp that referenced this pull request Jun 27, 2024
Checking changes in eclipse-uprotocol#64 enable eclipse-uprotocol#54 to proceed

Merge remote-tracking branch 'sasha/zenoh-utransport-impl' into check/add-zenohcpp-conan
@gregmedd gregmedd marked this pull request as ready for review June 27, 2024 19:37
@gregmedd
Copy link
Contributor Author

I have validated that this change fixes the build issues blocking #54 in a separate branch where #54 has been merged with this PR.

A few changes will be needed to the code in #54. I will upload a patch here and in the other PR

@gregmedd
Copy link
Contributor Author

Patch file: build_fixes.patch.tar.gz

(GitHub has a bug uploading .patch files from Linux, so it's wrapped in an archive)

@gregmedd gregmedd merged commit fb8581d into eclipse-uprotocol:main Jun 27, 2024
5 checks passed
@gregmedd gregmedd deleted the feature/1.5.8/add-zenohcpp-conan branch June 27, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants