Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common configuration patterns draft text #100

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hutchig
Copy link
Member

@hutchig hutchig commented Apr 2, 2019

This pull request is draft text to help resolve #98 and will be changed
with subsequest commits based on discussion.

Signed-off-by: Gordon Hutchison [email protected]

@hutchig hutchig requested review from kenfinnigan, Emily-Jiang, kwsutter and jclingan and removed request for kenfinnigan April 2, 2019 15:23
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
@Emily-Jiang
Copy link
Member

@hutchig I think this issue should be discussed at the architecture meeting managed by @kenfinnigan before the decision is made. Thanks for raising the issue!

@hutchig
Copy link
Member Author

hutchig commented Apr 3, 2019

@Emily-Jiang I agree, #98 is tagged as "Architecture board"

spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
spec/src/main/asciidoc/config.asciidoc Outdated Show resolved Hide resolved
@xstefank
Copy link
Member

@hutchig there are several open preference questions in the PR. Maybe the vote can be moved somewhere else to make it more visible?

@hutchig
Copy link
Member Author

hutchig commented May 21, 2019

Yes @xstefank it is true what you say and this PR is effectively 'stuck' until they are resolved. (Unless I descope the areas that are not resolved). I think I need to discuss a better means of progress in the architecture hangout maybe or perhaps the google group. There was a recent request to go 'fully asynch' like other open source projects. In which case the way forward would be to split of the unresolved parts of this PR to seperate smaller ones so they can be individually voted (+1-1) on.

@hutchig hutchig closed this May 21, 2019
@hutchig hutchig reopened this May 21, 2019
@hutchig
Copy link
Member Author

hutchig commented May 21, 2019

I will look to dropping another commit that removes text where anyone has expressed controversy and then call a vote somewhere publically (what is the set of people who can vote?)

@hutchig
Copy link
Member Author

hutchig commented Jun 17, 2019

The indication of empty set issue is being dealt with in eclipse/microprofile-config#397
The inclusion of "/" in a propert name is being dealt with in eclipse/microprofile-config#420

I think the text here now represents the best current opinion I can create.

@hutchig hutchig requested a review from pilhuhn June 17, 2019 13:08
@hutchig
Copy link
Member Author

hutchig commented Jun 24, 2019

I got a new laptop and have confused myself/git as Kevin's 3.0 commit are in the delta - I will sort out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document recommended usage patterns of MicroProfile Config (for use by other MicroProfile specifications)
7 participants