Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating simdjson to 3.9.5 #92

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

lemire
Copy link
Collaborator

@lemire lemire commented Jul 4, 2024

Fixes #91

@lemire lemire mentioned this pull request Jul 4, 2024
@eddelbuettel
Copy link
Owner

I don't remember from the top of my head whether I need manual mods but I think I don't so in in goes!

@eddelbuettel eddelbuettel merged commit 73f0c29 into eddelbuettel:master Jul 5, 2024
4 checks passed
@eddelbuettel
Copy link
Owner

Thanks again -- this is now on CRAN after an extra day it took for a manual / one-off check against the newer g++.

@eddelbuettel
Copy link
Owner

eddelbuettel commented Jul 7, 2024

@lemire I spoke too soon. Other email from Dortmund says

Thanks, we see:

Fedora-gcc 14:

Found the following significant warnings:
../inst/include/RcppSimdJson/deserialize/Type_Doctor.hpp:43:65: warning:
template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]

Please fix and resubmit.

Can you take a look, time permitting, and suggest a change? I am currently fighting a different fire with Rcpp.

Update 1: Worst case, as mentioned, I could enforce C++17, at least for now. Apparently we already compile as C++17 so that is not an option.

Update 2: The fix may be reasonably simple. At least I have something that passes muster under g++-13.

Update 3: Now on CRAN.

@lemire
Copy link
Collaborator Author

lemire commented Jul 7, 2024

Is there anything that needs to be done? The warning should be gone.

@eddelbuettel
Copy link
Owner

It's all good, I 'merely' had to remove the offending template-id in one ctor declaration on the R 'glue' side of the package.

The updated package (with simdjson 3.9.5) now on CRAN.

@eddelbuettel eddelbuettel mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN warnings with g++-14
2 participants