Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isNullTranstion which chokes if use ToLower #158

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

kant2002
Copy link
Contributor

Proposed Changes

Fix isNullTranstion which chokes if use ToLower

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@kant2002
Copy link
Contributor Author

@simon-reynolds can you take a look at PR?

@kant2002
Copy link
Contributor Author

@simon-reynolds I did fix formatting. Can you please take a look at PR?

@simon-reynolds
Copy link
Collaborator

Hi @kant2002, thank you so much for the PR, merged now
Will try get a release out soon

@simon-reynolds simon-reynolds merged commit 5bc850d into efcore:master Nov 21, 2023
3 checks passed
@kant2002 kant2002 deleted the kant/tolower branch November 22, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants