Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the commitment abstraction #499

Closed
th7nder opened this issue Nov 4, 2024 · 0 comments · Fixed by #566
Closed

Change the commitment abstraction #499

th7nder opened this issue Nov 4, 2024 · 0 comments · Fixed by #566
Assignees
@cernicc
Labels
tech debt Flags technical debt
Milestone
Phase 3

Comments

@th7nder
Copy link
Contributor

th7nder commented Nov 4, 2024 

          In retrospective. It would be better to have a newtype per specific commitment.

Originally posted by @cernicc in #483 (comment)
@th7nder th7nder mentioned this issue Nov 4, 2024
Merged
11 tasks
@cernicc cernicc self-assigned this Nov 13, 2024
@cernicc cernicc linked a pull request Nov 13, 2024 that will close this issue
feat(commitment): change abstraction #566
Merged
3 tasks
@jmg-duarte jmg-duarte added this to the Phase 3 milestone Nov 14, 2024
@jmg-duarte jmg-duarte added the tech debt Flags technical debt label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cernicc cernicc

Labels
tech debt Flags technical debt
Projects
None yet
Milestone
Phase 3
Development

Successfully merging a pull request may close this issue.

feat(commitment): change abstraction eigerco/polka-storage
3 participants
@cernicc @th7nder @jmg-duarte