Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commitment): change abstraction #566

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(commitment): change abstraction #566

merged 1 commit into from
Nov 19, 2024

Conversation

cernicc
Copy link
Member

@cernicc cernicc commented Nov 13, 2024

Description

Change commitment abstraction. It looks much better than before. We should probably merge this after the p2 delivery.

Checklist

  • Make sure that you described what this change does.
  • Have you tested this solution?
  • Did you document new (or modified) APIs?

@cernicc cernicc requested a review from a team November 13, 2024 20:21
@cernicc cernicc self-assigned this Nov 13, 2024
@cernicc cernicc linked an issue Nov 13, 2024 that may be closed by this pull request
Change the commitment abstraction #499
Closed
th7nder
th7nder approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@th7nder th7nder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks soo much more readable and less error-prone, great job bro!

jmg-duarte
jmg-duarte requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@jmg-duarte jmg-duarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(blocking merges until we officially finish p2)

@cernicc cernicc force-pushed the feat/499/commitment-abstraction branch from e597d1a to bcb4ecd Compare November 18, 2024 09:49
@jmg-duarte jmg-duarte force-pushed the feat/499/commitment-abstraction branch from bcb4ecd to d7b3570 Compare November 18, 2024 22:18
@jmg-duarte jmg-duarte added the ready for review Review is needed label Nov 18, 2024
@jmg-duarte jmg-duarte enabled auto-merge (squash) November 18, 2024 22:18
@jmg-duarte jmg-duarte merged commit 26c7143 into develop Nov 19, 2024
5 checks passed
@jmg-duarte jmg-duarte deleted the feat/499/commitment-abstraction branch November 19, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidan46 aidan46 aidan46 left review comments

@jmg-duarte jmg-duarte jmg-duarte approved these changes

@th7nder th7nder th7nder approved these changes

@pete-eiger pete-eiger Awaiting requested review from pete-eiger

Assignees

@cernicc cernicc

Labels
ready for review Review is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the commitment abstraction
4 participants
@cernicc @th7nder @jmg-duarte @aidan46