-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add CI and Task for formatting R and Rust code #73
Draft
etiennebacher
wants to merge
14
commits into
eitsupi:main
Choose a base branch
from
etiennebacher:setup-fmt-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebacher
commented
Jan 23, 2025
install-air: | ||
desc: Install Air to format R code. | ||
cmds: | ||
- curl -LsSf https://github.com/posit-dev/air/releases/latest/download/air-installer.sh | sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is downloaded every time task fmt
runs, which is bad. @eitsupi do you know why this is executed while other setup tasks are skipped? Is it because this is a curl command and there's no way to know if it's outdated?
261a141
to
fa2bbd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72
Putting this in draft until a few issues and features are complete in
air
, specifically:ignore files generated by==> Donesavvy
: Add a default set of files / folders to ignore posit-dev/air#128 (comment)tribble()
: Tabular formatting posit-dev/air#113. Currently those are completely expanded vertically. Alternatively, add suppression comments around those (Add suppression comment support posit-dev/air#52) depending on which of those features lands first inair
.becomes:
When those are fixed, I'll make a separate PR where I actually run the formatters so that this PR is not drowned in formatting changes.